netdev - Re: [PATCH] net: mvneta: enable features before registering the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130408.121604.421731991206410747.davem@davemloft.net>
Date:	Mon, 08 Apr 2013 12:16:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	w@....eu
Cc:	netdev@...r.kernel.org, thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH] net: mvneta: enable features before registering the
 driver

From: Willy Tarreau <w@....eu>
Date: Sat, 6 Apr 2013 20:47:01 +0200

> Hi,
> 
> I noticed that mvneta's tx-csum/sg were off until disabled then
> enabled, which led me to think that something was not made in the
> correct sequence. And indeed, setting the dev features _before_
> registering the device works much better :-)
> 
> This patch is for master but may be backported to 3.8-stable as well,
> which is where I first experienced the issue.

Please don't post patches like this, you make extra work for the
maintainer by having to edit out this commentary.

You put such commentary after the "---" seperator the delineates
your commit message in the email body, not before.

Anyways, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html