netdev - Re: [PATCH] tcp: assign the sock correctly to an outgoing SYNACK packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365467636.3887.67.camel@edumazet-glaptop>
Date:	Mon, 08 Apr 2013 17:33:56 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Casey Schaufler <casey@...aufler-ca.com>
Cc:	David Miller <davem@...emloft.net>, pmoore@...hat.com,
	netdev@...r.kernel.org, mvadkert@...hat.com, selinux@...ho.nsa.gov,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH] tcp: assign the sock correctly to an outgoing SYNACK
 packet

On Mon, 2013-04-08 at 16:40 -0700, Casey Schaufler wrote:

> OK, let's do the math.
> 
> First off, it's 4 bytes, not 8. It replaces the secmark.
> Your increased memory usage is going to be
> 
> 	4 bytes/packet *  M packets/second * N seconds
> 
> Where M is the rate at which you're processing packets and
> N is the length of time it takes to process a packet.
> 
> Let's pretend we have an embedded system that does nothing but send
> 128 byte packets on a 10Gb port. That's 10M packets/second. If it
> takes a full second to process a packet the overhead is 40MB for that
> second. I have it on good authority that packets can be processed
> in considerably less time than that. The real number is more like
> 0.05 seconds. That means your actual overhead is more like 1MB.
> 
> These are dumbed down calculations. I am not a memory usage expert.
> I am convinced that "real" calculations are going to get similar
> numbers. I am, of course, willing to be swayed by evidence that I
> am wrong.
> 
> Compare that to the overhead associated with using CIPSO on packets
> that never leave the box.

Maths are not that simple, and its not about size of sk_buff, since the
number of in-flight skb should be quite small.

Its the time to init this memory for _every_ packet.

sizeof(sk_buff) is 0xf8, very close to cross the 256 bytes limit.

Add a single _byte_ and it becomes a matter of adding a _cache_ line,
and thats 25 % cost, assuming 64bytes cache lines.

So instead of processing 10M packets per second, we would process 9M
packets per second, or maybe less.

Yes, 256 bytes per sk_buff, this is the current insane situation.
(Not counting the struct skb_shared_info, adding at least one additional
cache line)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html