[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130409.132350.1681660673457923647.davem@davemloft.net>
Date: Tue, 09 Apr 2013 13:23:50 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: pmoore@...hat.com, netdev@...r.kernel.org, mvadkert@...hat.com,
linux-security-module@...r.kernel.org
Subject: Re: [PATCH] selinux: add a skb_owned_by() hook
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 08 Apr 2013 20:58:11 -0700
> From: Eric Dumazet <edumazet@...gle.com>
>
> Commit 90ba9b1986b5ac (tcp: tcp_make_synack() can use alloc_skb())
> broke certain SELinux/NetLabel configurations by no longer correctly
> assigning the sock to the outgoing SYNACK packet.
>
> Cost of atomic operations on the LISTEN socket is quite big,
> and we would like it to happen only if really needed.
>
> This patch introduces a new security_ops->skb_owned_by() method,
> that is a void operation unless selinux is active.
>
> Reported-by: Miroslav Vadkerti <mvadkert@...hat.com>
> Diagnosed-by: Paul Moore <pmoore@...hat.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
Since this fixes a regression that got added by the networking
tree, I'll push this to Linus, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists