netdev - Re: [PATCH net-next] tg3: Use bool not int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130409.170815.1687417824367136494.davem@davemloft.net>
Date:	Tue, 09 Apr 2013 17:08:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	joe@...ches.com, nsujir@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tg3: Use bool not int

From: "Michael Chan" <mchan@...adcom.com>
Date: Tue, 9 Apr 2013 14:00:11 -0700

> On Tue, 2013-04-09 at 13:18 -0700, Joe Perches wrote:
>> Using bool can make code more readable.
>> 
>> Convert uses and tests of int to bool.
>> 
>> This also makes a comparison of tg3->link_up
>> (itself bool) a bool comparison instead of int.
>> 
>> Reorder stack variable declarations to make
>> bool fit declaration holes where appropriate.
>> 
>> $ size drivers/net/ethernet/broadcom/tg3.o*
>>    text    data     bss     dec     hex filename
>>  169958   27249   58896  256103   3e867 drivers/net/ethernet/broadcom/tg3.o.new
>>  169968   27249   58896  256113   3e871 drivers/net/ethernet/broadcom/tg3.o.old
>> 
>> Signed-off-by: Joe Perches <joe@...ches.com> 
> 
> Thanks.
> 
> Reviewed-by: Michael Chan <mchan@...adcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html