lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 10 Apr 2013 16:43:12 +0400
From:	Denis Kirjanov <kda@...ux-powerpc.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Jason Baron <jbaron@...hat.com>, netdev@...r.kernel.org,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] lib, net: make isodigit public and use it

what about #define isoctal(c) (((c) & ~7) ?

On 4/10/13, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> There are at least two users of isodigit. Let's make it a public function
> of
> ctype.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  include/linux/ctype.h | 6 ++++++
>  lib/dynamic_debug.c   | 1 -
>  net/sunrpc/cache.c    | 1 -
>  3 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/ctype.h b/include/linux/ctype.h
> index 8acfe31..653589e 100644
> --- a/include/linux/ctype.h
> +++ b/include/linux/ctype.h
> @@ -61,4 +61,10 @@ static inline char _tolower(const char c)
>  	return c | 0x20;
>  }
>
> +/* Fast check for octal digit */
> +static inline int isodigit(const char c)
> +{
> +	return c >= '0' && c <= '7';
> +}
> +
>  #endif
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index 5276b99..4603245 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -281,7 +281,6 @@ static inline int parse_lineno(const char *str, unsigned
> int *val)
>   * allow the user to express a query which matches a format
>   * containing embedded spaces.
>   */
> -#define isodigit(c)		((c) >= '0' && (c) <= '7')
>  static char *unescape(char *str)
>  {
>  	char *in = str;
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 05ea9ac..80fe5c8 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -1210,7 +1210,6 @@ EXPORT_SYMBOL_GPL(sunrpc_cache_pipe_upcall);
>   * key and content are both parsed by cache
>   */
>
> -#define isodigit(c) (isdigit(c) && c <= '7')
>  int qword_get(char **bpp, char *dest, int bufsize)
>  {
>  	/* return bytes copied, or -1 on error */
> --
> 1.8.2.rc0.22.gb3600c3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists