netdev - Re: [PATCH iproute2] vxlan: Allow setting unicast address to the group address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130410094639.748d022f@nehalam.linuxnetplumber.net>
Date:	Wed, 10 Apr 2013 09:46:39 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Atzm Watanabe <atzm@...atosphere.co.jp>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] vxlan: Allow setting unicast address to the
 group address

On Wed, 10 Apr 2013 17:52:05 +0900
Atzm Watanabe <atzm@...atosphere.co.jp> wrote:

> This patch allows setting unicast address to the VXLAN group address.
> It allows that VXLAN can be used as peer-to-peer tunnel without
> multicast.
> 
> Signed-off-by: Atzm Watanabe <atzm@...atosphere.co.jp>
> ---
>  ip/iplink_vxlan.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> index 1025326..cfe324c 100644
> --- a/ip/iplink_vxlan.c
> +++ b/ip/iplink_vxlan.c
> @@ -66,9 +66,6 @@ static int vxlan_parse_opt(struct link_util *lu, int argc, char **argv,
>  		} else if (!matches(*argv, "group")) {
>  			NEXT_ARG();
>  			gaddr = get_addr32(*argv);
> -
> -			if (!IN_MULTICAST(ntohl(gaddr)))
> -				invarg("invald group address", *argv);
>  		} else if (!matches(*argv, "local")) {
>  			NEXT_ARG();
>  			if (strcmp(*argv, "any"))

Could you use another name or argument to express the different intended behavior.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html