netdev - Re: [PATCH] ipconfig: stop ip-config if disabled method directed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130410.231935.1794061214116167901.davem@davemloft.net>
Date:	Wed, 10 Apr 2013 23:19:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	takashi.yoshii.zj@...esas.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipconfig: stop ip-config if disabled method directed

From: Takashi Yoshii <takashi.yoshii.zj@...esas.com>
Date: Wed, 10 Apr 2013 16:23:54 +0900

> Looks insignificant, but a misusage of kernel level auto configuration
> results in an invalid ipv4 address set.
> That is a kind of corner case, but I think it is be better sanitizing
>  the input a bit more for our simple in_aton().
> --
> 
> CONFIG_IP_PNP=y
> CONFIG_IP_PNP_DHCP=n
> Command line: ip=dhcp
> result in false ip address 62.0.0.0 set.
> 
> If directed autoconf method is not compiled into the kernel,
> ip-config should be terminated.
> 
> Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@...esas.com>

This is a poor submission.

When you put _before_ the "--" is the commit message, and the
text afterwards will be removed and not considered as part of
the commit message.

Secondly, put this logic into ic_proto_name() so we don't duplicate
all of these string comparisons.

Thirdly, consider simply removing all of these silly Kconfig
options, they seem rediculous.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html