netdev - Re: [PATCH v2] can: sja1000: fix endian on arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365706413.4136.15.camel@mars>
Date:	Thu, 11 Apr 2013 20:53:33 +0200
From:	Christoph Fritz <chf.fritz@...glemail.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	Wolfgang Grandegger <wg@...ndegger.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	linux-can@...r.kernel.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Andreas Larsson <andreas@...sler.com>,
	"Hans J. Koch" <hjk@...sjkoch.de>,
	Bill Pemberton <wfp5p@...ginia.edu>,
	Daniel Mack <daniel@...que.org>
Subject: Re: [PATCH v2] can: sja1000: fix endian on arm

On Thu, 2013-04-11 at 20:47 +0200, Marc Kleine-Budde wrote:
> On 04/11/2013 08:44 PM, Christoph Fritz wrote:
> > To get correct endian on arm cpus while reading device tree properties,
> > this patch replaces of_get_property() with of_property_read_u32().
> > 
> > Signed-off-by: Christoph Fritz <chf.fritz@...glemail.com>
> 
> looks good, one nitpick inline
> 
> > ---
> >  drivers/net/can/sja1000/sja1000_of_platform.c |   32 ++++++++++++-------------
> >  1 file changed, 16 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c b/drivers/net/can/sja1000/sja1000_of_platform.c

> > @@ -168,8 +168,8 @@ static int sja1000_ofp_probe(struct platform_device *ofdev)
> >  		priv->cdr |= CDR_CLK_OFF; /* default */
> >  	}
> >  
> > -	prop = of_get_property(np, "nxp,no-comparator-bypass", NULL);
> > -	if (!prop)
> > +	err = of_property_read_u32(np, "nxp,no-comparator-bypass", &prop);
> 
> What about using of_property_read_bool instead?

 Yeah, that would be better, thanks - let me re-roll this.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html