netdev - Re: [PATCH] net: mv643xx_eth: remove deprecated inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51671494.6000803@gmail.com>
Date:	Thu, 11 Apr 2013 21:52:52 +0200
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Lennert Buytenhek <buytenh@...tstofly.org>,
	Andrew Lunn <andrew@...n.ch>,
	Jason Cooper <jason@...edaemon.net>,
	Florian Fainelli <florian@...nwrt.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Dale Farnsworth <dale@...nsworth.org>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Soeren Moch <smoch@....de>, Willy Tarreau <w@....eu>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mv643xx_eth: remove deprecated inet_lro support

On 04/11/2013 09:46 PM, Eric Dumazet wrote:
> On Thu, 2013-04-11 at 21:11 +0200, Sebastian Hesselbarth wrote:
>> With recent support for GRO, there is no need to keep both LRO and
>> GRO. This patch therefore removes the deprecated inet_lro support
>> from mv643xx_eth. This is work is based on an experimental patch
>> provided by Eric Dumazet and Willy Tarreau.
>>
>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@...il.com>
>> Based-on-patch-by: Eric Dumazet<eric.dumazet@...il.com>
>> Based-on-patch-by: Willy Tarreau<w@....eu>
>> ---
>> Note: This patch is based upon recent cleanup patches and GRO support
>> patch for mv643xx_eth.
>>
>> Cc: "David S. Miller"<davem@...emloft.net>
>> Cc: Lennert Buytenhek<buytenh@...tstofly.org>
>> Cc: Andrew Lunn<andrew@...n.ch>
>> Cc: Jason Cooper<jason@...edaemon.net>
>> Cc: Florian Fainelli<florian@...nwrt.org>
>> Cc: Benjamin Herrenschmidt<benh@...nel.crashing.org>
>> Cc: Paul Mackerras<paulus@...ba.org>
>> Cc: Dale Farnsworth<dale@...nsworth.org>
>> Cc: Ben Hutchings<bhutchings@...arflare.com>
>> Cc: Soeren Moch<smoch@....de>
>> Cc: Eric Dumazet<eric.dumazet@...il.com>
>> Cc: Willy Tarreau<w@....eu>
>> Cc: netdev@...r.kernel.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linuxppc-dev@...ts.ozlabs.org
>> Cc: linux-kernel@...r.kernel.org
>> ---
>>   drivers/net/ethernet/marvell/mv643xx_eth.c |   97 +---------------------------
>>   1 file changed, 3 insertions(+), 94 deletions(-)
>
> Seems fine to me, but you also could remove "select INET_LRO"
> from drivers/net/ethernet/marvell/Kconfig

Ok, I will wait for tomorrow to see if there are more objections and
respin a v2.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html