| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Apr 2013 18:03:09 +0800 From: Ming Lei <tom.leiming@...il.com> To: Oliver Neukum <oliver@...kum.org> Cc: Dan Williams <dcbw@...hat.com>, Elina Pasheva <epasheva@...rrawireless.com>, Network Development <netdev@...r.kernel.org>, linux-usb <linux-usb@...r.kernel.org>, Rory Filer <rfiler@...rrawireless.com>, Phil Sutter <phil@....cc> Subject: Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active On Thu, Apr 11, 2013 at 5:53 PM, Oliver Neukum <oliver@...kum.org> wrote: > On Thursday 11 April 2013 16:09:16 Ming Lei wrote: >> >> Could you explain why work queue need GFP_NOIO? > > Your fix for the memory allocation depends on it happening in the same > context. If you execute code on a work queue this happens in the context > of a kernel thread. I understand the interface might be called from workqueue, and my question is why GFP_NOIO is needed in the work queue context. Generally speaking, GFP_KERNEL is enough for work queue context. As we discussed before, GFP_NOIO is required in runtime resume context and reset context, and the two contexts have been addressed automatically. So looks you didn't answer my question, :-) I mean if GFP_NOIO isn't needed, we can use GFP_KERNEL directly, and the extra parameter isn't need. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists