netdev - Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1762413.DH0n5NjUdu@linux-5eaq.site>
Date:	Thu, 11 Apr 2013 13:54:08 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Bjørn Mork <bjorn@...k.no>,
	Dan Williams <dcbw@...hat.com>,
	Elina Pasheva <epasheva@...rrawireless.com>,
	Network Development <netdev@...r.kernel.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	Rory Filer <rfiler@...rrawireless.com>,
	Phil Sutter <phil@....cc>
Subject: Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thursday 11 April 2013 19:42:53 Ming Lei wrote:
> On Thu, Apr 11, 2013 at 7:08 PM, Bjørn Mork <bjorn@...k.no> wrote:
> >
> > The docs for usb_submit_urb() in drivers/usb/core/urb.c lists some
> > possible mem_flags use cases. Among these are (where (b) and (c) are
> > cases needing GFP_ATOMIC and not applicable here):
> >
> > <quote>
> >  *  (3) If you use a kernel thread with a network driver you must use
> >  *      GFP_NOIO, unless (b) or (c) apply;
> > </quote>
> >
> > Is this example
> >  a) wrong, or
> >  b) not applicable, or
> >  c) to be excluded from the new API?
> 
> IMO, it may be a) or b), and we can find many GFP_KERNEL usage
> inside usbnet(kevent(), ...).

Only in the rx path.

> Also (3) doesn't explain the cause. Oliver, could you give a hit?

IIRC this was to cover networked file systems.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html