netdev - Re: [PATCH V4 7/7] xen-netback: don't disconnect frontend when seeing oversize packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ75kXb1Pc83sAjqDuzeGiikTcqdqrgPTxTT7kS-agUqoZp7LA@mail.gmail.com>
Date:	Fri, 12 Apr 2013 19:17:38 +0200
From:	William Dauchy <wdauchy@...il.com>
To:	Wei Liu <wei.liu2@...rix.com>
Cc:	netdev@...r.kernel.org, xen-devel <xen-devel@...ts.xen.org>,
	annie.li@...cle.com,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"jbeulich@...e.com" <jbeulich@...e.com>,
	Ian Campbell <ian.campbell@...rix.com>, david.vrabel@...rix.com
Subject: Re: [PATCH V4 7/7] xen-netback: don't disconnect frontend when seeing
 oversize packet

On Fri, Apr 12, 2013 at 4:24 PM, Wei Liu <wei.liu2@...rix.com> wrote:
> Some frontend drivers are sending packets > 64 KiB in length. This length
> overflows the length field in the first slot making the following slots have
> an invalid length.
>
> Turn this error back into a non-fatal error by dropping the packet. To avoid
> having the following slots having fatal errors, consume all slots in the
> packet.
>
> This does not reopen the security hole in XSA-39 as if the packet as an
> invalid number of slots it will still hit fatal error case.
>
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>
> Signed-off-by: Wei Liu <wei.liu2@...rix.com>

Maybe this should be tagged for stable? Maybe part of patch 6/7 as
well. I had to remove the part which was disabling the device because
of issues encountered in stable tree.

--
William
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html