netdev - Re: [PATCH] tuntap: fix error return code in tun_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130412.150036.858312621256997624.davem@davemloft.net>
Date:	Fri, 12 Apr 2013 15:00:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	weiyj.lk@...il.com, jasowang@...hat.com, mst@...hat.com,
	edumazet@...gle.com, nhorman@...driver.com,
	yongjun_wei@...ndmicro.com.cn, netdev@...r.kernel.org
Subject: Re: [PATCH] tuntap: fix error return code in tun_set_iff()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 12 Apr 2013 06:49:20 -0700

> On Fri, 2013-04-12 at 21:17 +0800, Wei Yongjun wrote:
>> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>> 
>> Fix to return a negative error code from the error handling
>> case instead of 0, as returned elsewhere in this function.
>> 
>> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>> ---
>>  drivers/net/tun.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index b7c457a..729ed53 100644
>> --- a/drivers/net/tun.c
>> +++ b/drivers/net/tun.c
>> @@ -1594,7 +1594,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
>>  
>>  		if (tun->flags & TUN_TAP_MQ &&
>>  		    (tun->numqueues + tun->numdisabled > 1))
>> -			return err;
>> +			return -EBUSY;
>>  	}
>>  	else {
>>  		char *name;
> 
> Bug added in linux-3.8 , commit 4008e97f866db665 
> ("tuntap: fix ambigious multiqueue API")
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html