netdev - Re: [PATCH] net: usb: active URB submitted multiple times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130412.151824.2029469075886743722.davem@davemloft.net>
Date:	Fri, 12 Apr 2013 15:18:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	petkan@...leusys.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	sarah.a.sharp@...ux.intel.com, dcbw@...hat.com
Subject: Re: [PATCH] net: usb: active URB submitted multiple times

From: Petko Manolov <petkan@...leusys.com>
Date: Thu, 11 Apr 2013 22:00:59 +0300 (EEST)

> From: Petko Manolov <petkan@...leusys.com>
> 
> (For inclusion in 3.10, diff against latest net-next.)
> 
> Pegasus driver used single callback for sync and async control URBs. 
> Special flags were employed to distinguish between both, but due to flawed 
> logic (as Sarah Sharp spotted) it didn't always work.  As a result of this 
> change [get|set]_registers() are now much simpler.  Async write is also 
> leaner and does not use single, statically allocated memory for 
> usb_ctrlrequest, which is another potential race when asynchronously 
> submitting URBs.
> 
> The socket buffer pool for the receive path is now gone.  It's existence 
> didn't make much difference (performance-wise) and the code is better off 
> without the spinlocks protecting it.
> 
> Largely duplicated code in routines reading and writing MII registers is 
> now packed in __mii_op().
> 
> Adding URL for the public pegasus git repository.
> 
> Signed-off-by: Petko Manolov <petkan@...leusys.com>

When submitting a new version of a patch, you must list what
changed from the previous version after the "---" delimiter
rather than having people try and guess.

> +T:	git git://petkan@....code.sf.net/p/pegasus2/git

There is no way that specifying your GIT login in this URL
meant for public use is correct, or is it?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html