netdev - RE: [PATCH] net: Fix tentative IPv6 address due to DAD looping back

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <027526AF93736D4380632CD4F3B42B80030B70@MX101CL02.corp.emc.com>
Date:	Fri, 12 Apr 2013 07:40:04 +0000
From:	"Meng, Jilin" <Jilin.Meng@....com>
To:	David Miller <davem@...emloft.net>
CC:	"kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>,
	"jmorris@...ei.org" <jmorris@...ei.org>,
	"yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
	"kaber@...sh.net" <kaber@...sh.net>,
	"Sun, Yinglin" <yinglin.sun@....com>,
	"Prithviraj, Lakshmanan" <lakshmanan.prithviraj@....com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: Fix tentative IPv6 address due to DAD looping back

>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net] 
>Sent: Thursday, April 11, 2013 11:15 AM
>To: Meng, Jilin
>Cc: kuznet@....inr.ac.ru; jmorris@...ei.org; yoshfuji@...ux-ipv6.org; kaber@...sh.net; Sun, Yinglin; Prithviraj, Lakshmanan; netdev@...r.kernel.org
>Subject: Re: [PATCH] net: Fix tentative IPv6 address due to DAD looping back
>
>From: "Meng, Jilin" <Jilin.Meng@....com>
>Date: Thu, 11 Apr 2013 03:06:23 +0000
>
>> we should ignore the looped-back IPv6 DAD packet to avoid configuration failure.
>> This occurs when a bonding interface with roundrobin mode is being configured an IPv6 address while the switch side isn't configured bonding/channel yet.
>
>Please don't submit long lines in your commit message, place a newline before the 80th column.
>
>> +				if (dev->type == ARPHRD_ETHER) {
>> +					const unsigned char *sadr;
>> +					sadr = skb_mac_header(skb);
>
>Add an empty line between the "sadr" variable declaration and the assignment.
>
>> +					if (ether_addr_equal_64bits(sadr + 6, dev->dev_addr))
>> +					/*
>> +					 * looped-back to us. This occurs when
>> +					 * a bonding interface with roundrobin
>> +					 * mode is being configured while the
>> +					 * switch side isn't configured yet.
>> +					 */
>> +						goto out;
>
>This had improper coding style in at least 2 different aspects.
>
>First, either put the comment before the if() statement, or if you absolutely must put it inside the basic block of the if() statement, add braces.
>
>Second, the comment is improperly formatted for the networking.  It should be formatted:
>
>	/* Like
>	 * this.
>	 */
>
>Finally, what do you mean when you ask for your message to be "recalled"?  That's awkward and doesn't mean anything to us.  Where else have you seen people use that terminology on a mailing list?
>
>Instead, just say "please ignore this patch, I have a new version coming".
>
>Then, when you post the new patch, tell us what changed from the previous submission.
>
>Not a good patch submission at all, and I haven't even thought about the logic of your change at all.
>

Thanks David. I learned much from you.

-Jilin

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html