netdev - Re: [PATCH 1/2 v2] at86rf230: add irq type configuration option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130412.182053.1145964817189847292.davem@davemloft.net>
Date:	Fri, 12 Apr 2013 18:20:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sascha@...nvbi.de
Cc:	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com
Subject: Re: [PATCH 1/2 v2] at86rf230: add irq type configuration option

From: Sascha Herrmann <sascha@...nvbi.de>
Date: Fri, 12 Apr 2013 00:16:13 +0200

>  static int at86rf230_hw_init(struct at86rf230_local *lp)
>  {
>  	u8 status;
> -	int rc;
> +	int rc, irq_pol;
> +	struct at86rf230_platform_data *pdata = lp->spi->dev.platform_data;

Please order local variable declarations from longest line to
shortest line, not the other way around.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html