netdev - Re: [RFC PATCH] udp: don't rereference dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130412.183251.1449847994152577369.davem@davemloft.net>
Date:	Fri, 12 Apr 2013 18:32:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	tparkin@...alix.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] udp: don't rereference dst_entry dev pointer on rcv

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 11 Apr 2013 15:26:33 -0700

> On Thu, 2013-04-11 at 10:53 -0700, Eric Dumazet wrote:
>> On Thu, 2013-04-11 at 09:32 -0700, Eric Dumazet wrote:
>> 
>> > Short update : I do not understand yet why this patch is not working.
>> > 
>> > Normally, the reassembled packet should get the dst from the last skb
>> > (the one completing the packet)...
>> > 
>> > I have to make more experiments.
>> 
>> OK I think I've nailed it, please try following patch (I tried it on
>> net-next, but it should apply on previous kernels)
> 
> By the way I am ashamed by commit 64f3b9e203bd068550
> (net: ip_expire() must revalidate route)
> 
> Reading its changelog now, I understand I should have fixed this the
> way we did today...
> 
> :(

There is still time to do it the right way Eric :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html