netdev - Re: [PATCH 4/7] xen-netfront: frags -> slots in log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Apr 2013 18:40:06 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>,
	Ian Campbell <Ian.Campbell@...rix.com>,
	David Vrabel <david.vrabel@...rix.com>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	"annie.li@...cle.com" <annie.li@...cle.com>,
	"wdauchy@...il.com" <wdauchy@...il.com>
Subject: Re: [PATCH 4/7] xen-netfront: frags -> slots in log message

Hello.

On 09-04-2013 17:47, Wei Liu wrote:

>>> Also fix a typo in comment.

>>> Signed-off-by: Wei Liu <wei.liu2@...rix.com>
>>> ---
>>>    drivers/net/xen-netfront.c |    4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)

>>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
>>> index d9097a7..1bb2e20 100644
>>> --- a/drivers/net/xen-netfront.c
>>> +++ b/drivers/net/xen-netfront.c
>> [...]
>>> @@ -771,7 +771,7 @@ next:
>>>
>>>    	if (unlikely(slots > max)) {
>>>    		if (net_ratelimit())
>>> -			dev_warn(dev, "Too many frags\n");
>>> +			dev_warn(dev, "Too many slots\n");
>>
>>      Shouldn't you have done this change as a part of patch #2?

> Because patch 2 has been applied to David Miller's tree, this is an
> incremental patch on top of that.

    Why are you reposting already applied patch over and over again then?

> Wei.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html