netdev - Re: [PATCH] net: mvmdio: add select PHYLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130413.164834.1146247422887398317.davem@davemloft.net>
Date:	Sat, 13 Apr 2013 16:48:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.petazzoni@...e-electrons.com
Cc:	netdev@...r.kernel.org, andrew@...n.ch, jason@...edaemon.net,
	maen@...vell.com, alior@...vell.com,
	gregory.clement@...e-electrons.com,
	ezequiel.garcia@...e-electrons.com, florian@...nwrt.org
Subject: Re: [PATCH] net: mvmdio: add select PHYLIB

From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Date: Sat, 13 Apr 2013 18:18:56 +0200

> The mvmdio driver uses the phylib API, so it should select the PHYLIB
> symbol, otherwise, a build with mvmdio (but without mvneta) fails to
> build with undefined symbols such as mdiobus_unregister, mdiobus_free,
> etc.
> 
> The mvneta driver does not use the phylib API directly, so it does not
> need to select PHYLIB. It already selects the mvmdio driver anyway.
> 
> Historically, this problem is due to the fact that the PHY handling
> was originally part of mvneta, and was later moved to a separate
> driver, without updating the Kconfig select statements
> accordingly. And since there was no functional reason to use mvmdio
> without mvneta, this case was not tested.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html