netdev - Re: [PATCH net-next 3/9] qlcnic: Add identifying string for 83xx adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130414105524.GB30385@electric-eye.fr.zoreil.com>
Date:	Sun, 14 Apr 2013 12:55:24 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Shahed Shaikh <shahed.shaikh@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Dept_NX_Linux_NIC_Driver@...gic.com,
	Himanshu Madhani <himanshu.madhani@...gic.com>
Subject: Re: [PATCH net-next 3/9] qlcnic: Add identifying string for 83xx
 adapter

Shahed Shaikh <shahed.shaikh@...gic.com> :
[...]
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> index 0d00b2b..424a5e0 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -156,6 +156,37 @@ static const u32 qlcnic_reg_tbl[] = {
>  };
>  
>  static const struct qlcnic_board_info qlcnic_boards[] = {
> +	{0x1077, 0x8030, 0x1077, 0x24e,

You may consider adding a space after the curly brace at a later time.

> +	 "8300 Series Dual Port 10GbE Converged Network Adapter "
> +	 "(TCP/IP Networking)"},
> +	{0x1077, 0x8030, 0x1077, 0x243,

0x1077 is also known as PCI_VENDOR_ID_QLOGIC.

You should imho use a macro to factor out the vendor.

At your choice, you may:
1. try a second macro to paste "Converged Network Adapter (TCP/IP Networking)"
2. save some kernel memory through replacement of
   short_name[QLCNIC_MAX_BOARD_NAME_LEN] (short indeed :o) ) by a char **.

Nit: rework qlcnic_get_board_name to avoid its sprintf and 
     QLCNIC_MAX_BOARD_NAME_LEN sized string in qlcnic_probe.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html