netdev - Re: [PATCH net-next 5/9] qlcnic: Enable Interrupt Coalescing for 83xx adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130414105543.GD30385@electric-eye.fr.zoreil.com>
Date:	Sun, 14 Apr 2013 12:55:43 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Shahed Shaikh <shahed.shaikh@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Dept_NX_Linux_NIC_Driver@...gic.com,
	Himanshu Madhani <himanshu.madhani@...gic.com>
Subject: Re: [PATCH net-next 5/9] qlcnic: Enable Interrupt Coalescing for
 83xx adapter

Shahed Shaikh <shahed.shaikh@...gic.com> :
[...]
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> index 602d3e4..7551b18 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
(...]
> @@ -359,6 +365,8 @@ struct qlcnic_nic_intr_coalesce {
>  	u8	sts_ring_mask;
>  	u16	rx_packets;
>  	u16	rx_time_us;
> +	u16	tx_packets;
> +	u16	tx_time_us;

(ok)

[...]
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> index c9c342e..fdd1fe7 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
[...]
> @@ -1878,10 +1878,18 @@ void qlcnic_83xx_config_intr_coal(struct qlcnic_adapter *adapter)
>  		return;
>  
>  	qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_CONFIG_INTR_COAL);
> -	cmd.req.arg[1] = 1 | (adapter->recv_ctx->context_id << 16);
> +	if (coal->type == QLCNIC_INTR_COAL_TYPE_RX) {
> +		temp = adapter->recv_ctx->context_id;
> +		cmd.req.arg[1] = (QLCNIC_INTR_COAL_TYPE_RX | (temp << 16));
> +		temp = coal->rx_time_us;
> +		cmd.req.arg[2] = (coal->rx_packets | (temp << 16));
> +	} else if (coal->type == QLCNIC_INTR_COAL_TYPE_TX) {
> +		temp = adapter->tx_ring->ctx_id;
> +		cmd.req.arg[1] = (QLCNIC_INTR_COAL_TYPE_TX | (temp << 16));
> +		temp = coal->rx_time_us;
                             ^^ -> tx ?
> +		cmd.req.arg[2] = (coal->rx_packets | (temp << 16));
                                        ^^ -> tx ?

[...]
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -1586,6 +1586,8 @@ out:
>  static int qlcnic_alloc_adapter_resources(struct qlcnic_adapter *adapter)
>  {
>  	int err = 0;
> +	struct qlcnic_hardware_context *ahw = adapter->ahw;
> +

Nit: long lines ought to appear first.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html