netdev - RE: [PATCH net-next 7/9] qlcnic: fix TSO race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 14 Apr 2013 17:55:45 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>,
	Sritej Velaga <sritej.velaga@...gic.com>
Subject: RE: [PATCH net-next 7/9] qlcnic: fix TSO race condition

> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Sunday, April 14, 2013 12:05 AM
> To: Shahed Shaikh
> Cc: David Miller; netdev; Dept-NX Linux NIC Driver; Sritej Velaga
> Subject: Re: [PATCH net-next 7/9] qlcnic: fix TSO race condition
>
>
> This looks like not needed at all.
>
> Take a look at all other network drivers.
>
> Not a single one does the (netdev->features & (NETIF_F_TSO |
> NETIF_F_TSO6)) check in their tx fast path.
>
> This is done by the core networking stacks.
>
> Just remove the check, and do not add an "invalid_tso_pkt", as there is
> nothing invalid here.
>
> If a driver advertised NETIF_F_TSO in its hw_features, then it _must_ be
> prepared to send TSO packets, even if the admin plays with "ethtool -k tso
> off".
>
> RTNL is not taken in TX path, so there is always the possibility a driver has to
> transmit a TSO packet right after the change.
>

Thanks Eric . We will look into your feedback.

-Shahed


________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.