[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20130414.152241.2174877623839388661.davem@davemloft.net>
Date: Sun, 14 Apr 2013 15:22:41 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: mr.dash.four@...glemail.com
Cc: netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH v2] iproute2: lib/utils.c bug fixes
From: Dash Four <mr.dash.four@...glemail.com>
Date: Sun, 14 Apr 2013 15:10:54 +0100
> This patch fixes the following 3 bugs in get_u32/get_u64 functions:
>
> 1. On 32-bit systems, get_u32 could not detect an overflow.
> get_u32(&l, "4294967296", 10) always returned 4294967295
> (ULONG_MAX on 32-bit systems).
>
> 2. get_u64(&ll, "4294967295", 10) was returning an error where
> it shouldn't have (4294967295 is perfectly legitimate value for
> unsigned long long).
>
> 3. get_u64 couldn't detect an overflow errors (arg > ULLONG_MAX)
>
> Changelog:
>
> v2 - Dropped name title from Developer Certificate of Origin
>
> Signed-off-by: Dash Four <mr.dash.four@...glemail.com>
Stephen already reimplmeneted your fixes in a slightly different
way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists