netdev - RE: [PATCH] net-packet: tx timestamping on tpacket ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Apr 2013 10:45:55 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Daniel Borkmann" <dborkman@...hat.com>,
	"Willem de Bruijn" <willemb@...gle.com>
Cc:	<paul.chavent@...ra.fr>, <richardcochran@...il.com>,
	<edumazet@...gle.com>, <daniel.borkmann@....ee.ethz.ch>,
	<xemul@...allels.com>, <ebiederm@...ssion.com>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH] net-packet: tx timestamping on tpacket ring

> > +	case TPACKET_V1:
> > +		h1 = frame;
> > +		h1->tp_sec = ts.tv_sec;
> > +		h1->tp_usec = ts.tv_nsec / NSEC_PER_USEC;
> > +
> > +		flush_dcache_page(pgv_to_page(&h1->tp_sec));
> > +		flush_dcache_page(pgv_to_page(&h1->tp_usec));
> 
> Hmm, not sure, but could we also flush the dcache only once?

If it isn't a silly question, why is the dcache being flushed
here at all?

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html