netdev - Re: [Patch net-next] ipv6: statically link register_inet6addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366024170.8361.12.camel@jlt4.sipsolutions.net>
Date:	Mon, 15 Apr 2013 13:09:30 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Tomas Melin <tomas.melin@....fi>
Cc:	Cong Wang <amwang@...hat.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	YOSHIFUJI Hidaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [Patch net-next] ipv6: statically link
 register_inet6addr_notifier()

On Mon, 2013-04-15 at 13:40 +0300, Tomas Melin wrote:
> On Sun, Apr 14, 2013 at 6:18 PM, Cong Wang <amwang@...hat.com> wrote:
> > From: Cong Wang <amwang@...hat.com>
> >
> > Tomas reported the following build error:
> >
> > net/built-in.o: In function `ieee80211_unregister_hw':
> > (.text+0x10f0e1): undefined reference to `unregister_inet6addr_notifier'
> > net/built-in.o: In function `ieee80211_register_hw':
> > (.text+0x10f610): undefined reference to `register_inet6addr_notifier'
> > make: *** [vmlinux] Error 1
> >
> > when built IPv6 as a module.
> >
> > So we have to statically link these symbols.
> >
> > Reported-by: Tomas Melin <tomas.melin@....fi>
> > Cc: Tomas Melin <tomas.melin@....fi>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: YOSHIFUJI Hidaki <yoshfuji@...ux-ipv6.org>
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> 
> This fixes the issue. Added Johannes Berg for information.

> > +++ b/net/ipv6/addrconf.c

> > -EXPORT_SYMBOL(register_inet6addr_notifier);

> > +++ b/net/ipv6/addrconf_core.c
> > @@ -78,3 +78,22 @@ int __ipv6_addr_type(const struct in6_addr *addr)
> >  }
> >  EXPORT_SYMBOL(__ipv6_addr_type);
> >
> > +static ATOMIC_NOTIFIER_HEAD(inet6addr_chain);
> > +
> > +int register_inet6addr_notifier(struct notifier_block *nb)
> > +{
> > +       return atomic_notifier_chain_register(&inet6addr_chain, nb);
> > +}
> > +EXPORT_SYMBOL(register_inet6addr_notifier);

That works for me, but it seems pretty pointless to have this API?
Anyway, let me know if you want to apply this patch, then I'll drop mine
and also remove the ifdefs from mac80211.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html