netdev - Re: [PATCH V4 7/7] xen-netback: don't disconnect frontend when seeing oversize packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Apr 2013 13:36:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	wei.liu2@...rix.com
Cc:	Ian.Campbell@...rix.com, wdauchy@...il.com, netdev@...r.kernel.org,
	xen-devel@...ts.xen.org, annie.li@...cle.com,
	konrad.wilk@...cle.com, jbeulich@...e.com, david.vrabel@...rix.com
Subject: Re: [PATCH V4 7/7] xen-netback: don't disconnect frontend when
 seeing oversize packet

From: Wei Liu <wei.liu2@...rix.com>
Date: Mon, 15 Apr 2013 16:30:38 +0100

> On Mon, Apr 15, 2013 at 04:24:49PM +0100, Ian Campbell wrote:
>> On Mon, 2013-04-15 at 15:53 +0100, Wei Liu wrote:
>> > On Mon, Apr 15, 2013 at 10:03:25AM +0100, Ian Campbell wrote:
>> > > On Fri, 2013-04-12 at 18:17 +0100, William Dauchy wrote:
>> > > > On Fri, Apr 12, 2013 at 4:24 PM, Wei Liu <wei.liu2@...rix.com> wrote:
>> > > > > Some frontend drivers are sending packets > 64 KiB in length. This length
>> > > > > overflows the length field in the first slot making the following slots have
>> > > > > an invalid length.
>> > > > >
>> > > > > Turn this error back into a non-fatal error by dropping the packet. To avoid
>> > > > > having the following slots having fatal errors, consume all slots in the
>> > > > > packet.
>> > > > >
>> > > > > This does not reopen the security hole in XSA-39 as if the packet as an
>> > > > > invalid number of slots it will still hit fatal error case.
>> > > > >
>> > > > > Signed-off-by: David Vrabel <david.vrabel@...rix.com>
>> > > > > Signed-off-by: Wei Liu <wei.liu2@...rix.com>
>> > > > 
>> > > > Maybe this should be tagged for stable? Maybe part of patch 6/7 as
>> > > > well. I had to remove the part which was disabling the device because
>> > > > of issues encountered in stable tree.
>> > > 
>> > > AFAICT the majority of this series (as well as perhaps some of Wei's
>> > > earlier fixes) should be candidates for any stable tree which received
>> > > the XSA-39 security fixes. Wei -- could you enumerate which patches are
>> > > required to fixup the XSA-39 regressions?
>> > > 
>> > 
>> > Are mechinical fixes such as removing redudent variables / changing log
>> > messages candidates for stable? 1-4 are such kind of fixes.
>> 
>> #4 looks like meat to me too?
>> 
> 
> Not really. DaveM applied first 3 and later I discoverd there was a log
> message which should have been changed in 2. So I wrote a incremental
> patch on top of 2 to fix that.

Please don't do this, it is so confusing.

When I've applied some of your patches, don't repost them, only post the
new patches which are not yet in my tree.

All development and patches occurs relative to my tree, so by reposting
patches already applied you make for confusion and more work on my part.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html