netdev - Re: [PATCH] fec: Use SIMPLE_DEV_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130416212531.GA19634@electric-eye.fr.zoreil.com>
Date:	Tue, 16 Apr 2013 23:25:31 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Fabio Estevam <festevam@...il.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] fec: Use SIMPLE_DEV_PM_OPS

Joe Perches <joe@...ches.com> :
> On Tue, 2013-04-16 at 21:11 +0400, Sergei Shtylyov wrote:
> > On 16-04-2013 19:22, Fabio Estevam wrote:
> > >>> +static SIMPLE_DEV_PM_OPS(fec_pm_ops, fec_suspend, fec_resume);
> > >>> +#define FEC_PM_OPS (&fec_pm_ops)
> > >>     Nit: parens are useless here.
> 
> Is this macro indirection even useful?

When CONFIG_PM_SLEEP is not set, it saves a few bytes setting the pm
reference to NULL instead of referencing a zero filled struct.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html