netdev - Re: [PATCH] atl1: Protect atl1_suspend with CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516DC66F.2000309@cogentembedded.com>
Date:	Wed, 17 Apr 2013 01:45:19 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Fabio Estevam <festevam@...il.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, joe@...ches.com,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] atl1: Protect atl1_suspend with CONFIG_PM_SLEEP

Hello.

On 04/17/2013 01:35 AM, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@...escale.com>
>
> commit 7b7a2bbb690 (atl1: Remove unneeded PM_OPS definitions) removed the
> definition of atl1_suspend for the !CONFIG_PM_SLEEP case.
>
> So only call atl1_suspend() when CONFIG_PM_SLEEP is defined and fix the
> following build error from randconfig:
>
> drivers/net/ethernet/atheros/atlx/atl1.c: In function 'atl1_shutdown':
> drivers/net/ethernet/atheros/atlx/atl1.c:2888:2: error: implicit declaration of function 'atl1_suspend' [-Werror=implicit-function-declaration]
>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>   drivers/net/ethernet/atheros/atlx/atl1.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c
> index 9843c70..8338013 100644
> --- a/drivers/net/ethernet/atheros/atlx/atl1.c
> +++ b/drivers/net/ethernet/atheros/atlx/atl1.c
> @@ -2885,7 +2885,9 @@ static void atl1_shutdown(struct pci_dev *pdev)
>   	struct net_device *netdev = pci_get_drvdata(pdev);
>   	struct atl1_adapter *adapter = netdev_priv(netdev);
>   
> +#ifdef CONFIG_PM_SLEEP
>   	atl1_suspend(&pdev->dev);
> +#endif

    This is not the best practice as #ifdef's in the function bodies are 
not encouraged.
Better enclose

atl1_suspend() in #ifdef CONFIG_PM_SLEEP
  and define it as an empty static inline function in the #else clause.


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html