netdev - [PATCH net-next] tlan: cancel work at remove path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Apr 2013 17:00:38 +0530
From:	Devendra Naga <devendra.aaru@...il.com>
To:	Samuel Chessman <chessman@....org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:	Devendra Naga <devendra.aaru@...il.com>, Sriram <srk@...com>,
	Cyril Chemparathy <cyril@...com>,
	Vinay Hegde <vinay.hegde@...com>
Subject: [PATCH net-next] tlan: cancel work at remove path

the work has been scheduled from interrupt, and not been
cancelled when the driver is unloaded, which doesn't remove
the work item from the global workqueue. call the
cancel_work_sync when the driver is removed (rmmod'ed).

Cc: Sriram <srk@...com>
Cc: Cyril Chemparathy <cyril@...com>
Cc: Vinay Hegde <vinay.hegde@...com>
Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
---

Hi,
	This is only compile tested and not tested
	on the the NIC which i dont have.

thanks

 drivers/net/ethernet/ti/tlan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index bdda36f..60c400f 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -320,6 +320,7 @@ static void tlan_remove_one(struct pci_dev *pdev)
 	free_netdev(dev);
 
 	pci_set_drvdata(pdev, NULL);
+	cancel_work_sync(&priv->tlan_tqueue);
 }
 
 static void tlan_start(struct net_device *dev)
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html