netdev - Re: [PATCH for 3.9] net: fec: fix regression in link change accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Apr 2013 10:40:39 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Lucas Stach <l.stach@...gutronix.de>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH for 3.9] net: fec: fix regression in link change accounting

Hi Lucas,

On Tue, Apr 16, 2013 at 7:42 AM, Lucas Stach <l.stach@...gutronix.de> wrote:
> A link-down isn't properly saved in the FEC state, so we wouldn't restart the
> FEC after a repeated link-up.
>
> Regression was introduced with commit
> d97e7497 "net: fec: restart the FEC when PHY speed changes"
>
> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> ---
>  drivers/net/ethernet/freescale/fec.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> index f292c3a..73195f6 100644
> --- a/drivers/net/ethernet/freescale/fec.c
> +++ b/drivers/net/ethernet/freescale/fec.c
> @@ -1002,6 +1002,7 @@ static void fec_enet_adjust_link(struct net_device *ndev)
>         } else {
>                 if (fep->link) {
>                         fec_stop(ndev);
> +                       fep->link = phy_dev->link;
>                         status_change = 1;
>                 }
>         }

I applied this into linux-next (the file is renamed to fec_main.c
there) and this fixes the suspend/resume issue I was seeing.

Tested-by: Fabio Estevam <fabio.estevam@...escale.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html