netdev - Re: [PATCH v3] vxlan: Allow setting destination to unicast address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y5cie59j.wl%atzm@stratosphere.co.jp>
Date:	Wed, 17 Apr 2013 02:48:08 +0900
From:	Atzm Watanabe <atzm@...atosphere.co.jp>
To:	Mike Rapoport <mike.rapoport@...ellosystems.com>
Cc:	David Stevens <dlstevens@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH v3] vxlan: Allow setting destination to unicast address.

At Tue, 16 Apr 2013 17:22:14 +0300,
Mike Rapoport wrote:
> 
> On Tue, Apr 16, 2013 at 3:50 PM, Atzm Watanabe <atzm@...atosphere.co.jp> wrote:
> > At Mon, 15 Apr 2013 16:53:35 -0400,
> > David Stevens wrote:
> >>
> >> netdev-owner@...r.kernel.org wrote on 04/12/2013 05:09:05 AM:
> >>
> >> > From: Atzm Watanabe <atzm@...atosphere.co.jp>
> >>
> >> > Signed-off-by: Atzm Watanabe <atzm@...atosphere.co.jp>
> >> > ---
> >> >  drivers/net/vxlan.c          | 45 +++++++++++++++++++++++++++++++++
> >> > +----------
> >> >  include/uapi/linux/if_link.h |  1 +
> >> >  2 files changed, 36 insertions(+), 10 deletions(-)
> >> >
> >> > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> >> > index 9a64715..e468d5a 100644
> >> > --- a/drivers/net/vxlan.c
> >> > +++ b/drivers/net/vxlan.c
> >> > @@ -106,7 +106,7 @@ struct vxlan_dev {
> >> >     struct hlist_node hlist;
> >> >     struct net_device *dev;
> >> >     __u32        vni;      /* virtual network id */
> >> > -   __be32             gaddr;   /* multicast group */
> >> > +   __be32             daddr;   /* destination address */
> >> >     __be32        saddr;   /* source address */
> >> >     unsigned int      link;      /* link to multicast over */
> >> >     __u16        port_min;   /* source port range */
> >>
> >>         This is effectively a default forwarding destination when
> >> there is no matching fdb entry. As such, I think a fully general
> >> patch would convert this to a "vxlan_rdst" and thereby allow alternate
> >> port, vni, specific outgoing interface and multiple remote destinations
> >> for copies, as via the fdb. And, in the future, support for this being
> >> an IPv6 destination, as well. I think the name here, "daddr", ought to
> >> reflect some of this too -- maybe "default_dst" or some such?
> >
> > Yes, right.  I'll replace "gaddr" with "default_dst" as vxlan_rdst.
> >
> > But to support multiple default destinations, it will need more fixes
> > like Mike Rapoport's patch.  Also it will need careful consideration
> > about VNI...  I'll try to fix them to support multiple default
> > destinations, after the patch is merged.
> 
> I can add multiple destinations myself if you'd prefer it that way :)

Great!

I think that supporting unicast address and supporting multiple
destinations are related (and similar on the code) but different
topics essentially.  So I'd appreciate it if you post the patch
(titled "support multiple default destinations" or some such) in
addition to my changes when it merged.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html