netdev - Re: [PATCH net] hyperv: Fix a compiler warning in netvsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130416.151141.1928940532005718606.davem@davemloft.net>
Date:	Tue, 16 Apr 2013 15:11:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	haiyangz@...rosoft.com
Cc:	netdev@...r.kernel.org, kys@...rosoft.com, olaf@...fle.de,
	jasowang@...hat.com, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org
Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Tue, 16 Apr 2013 12:03:51 -0700

> Fixed: warning: cast from pointer to integer of different size
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>

If you're coding pointers into request IDs you better make that
explicit and add lots of comments explaining why that's OK and
why it's going to work fine in these circumstances.

I'm not applying this patch, it just makes a bad situation even
worse.  Either your request IDs are 64-bit or they are not, it
can't be both.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html