netdev - Re: [PATCH net] hyperv: Fix a compiler warning in netvsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130416.154912.896506198616355113.davem@davemloft.net>
Date:	Tue, 16 Apr 2013 15:49:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	haiyangz@...rosoft.com
Cc:	netdev@...r.kernel.org, kys@...rosoft.com, olaf@...fle.de,
	jasowang@...hat.com, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org
Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Tue, 16 Apr 2013 19:34:52 +0000

> The Hyper-V hosts always use 64 bit request id. The guests can have
> 32 or 64 bit pointers which equal to the ulong type size. So we cast
> it to ulong type. And, assigning 32bit integer to 64 bit variable
> works fine.

It works fine, but it's unclean.

Keep the req_id type as "u64", because that's what it is, a 64-bit request ID.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html