netdev - Re: [PATCH 5/5] ks8851: Remove unneeded PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516DB4B1.9050602@metafoo.de>
Date:	Tue, 16 Apr 2013 22:29:37 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Fabio Estevam <fabio.estevam@...escale.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH 5/5] ks8851: Remove unneeded PM_OPS definitions

On 04/16/2013 09:28 PM, Fabio Estevam wrote:
> SIMPLE_DEV_PM_OPS macro can handle !CONFIG_PM_SLEEP case nicely, so there is no
> need to define PM_OPS for both CONFIG_PM_SLEEP and !CONFIG_PM_SLEEP cases.
> 
> Remove the unneeded definitions.
> 
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

yea, but now you have the dev_pm_ops struct, even if pm is disabled.

- Lars

> ---
>  drivers/net/ethernet/micrel/ks8851.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c
> index da64960..727b546a 100644
> --- a/drivers/net/ethernet/micrel/ks8851.c
> +++ b/drivers/net/ethernet/micrel/ks8851.c
> @@ -1391,13 +1391,9 @@ static int ks8851_resume(struct device *dev)
>  
>  	return 0;
>  }
> +#endif
>  
>  static SIMPLE_DEV_PM_OPS(ks8851_pm_ops, ks8851_suspend, ks8851_resume);
> -#define KS8851_PM_OPS (&ks8851_pm_ops)
> -
> -#else
> -#define KS8851_PM_OPS NULL
> -#endif
>  
>  static int ks8851_probe(struct spi_device *spi)
>  {
> @@ -1536,7 +1532,7 @@ static struct spi_driver ks8851_driver = {
>  	.driver = {
>  		.name = "ks8851",
>  		.owner = THIS_MODULE,
> -		.pm = KS8851_PM_OPS,
> +		.pm = &ks8851_pm_ops,
>  	},
>  	.probe = ks8851_probe,
>  	.remove = ks8851_remove,

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html