netdev - Re: [PATCH 12/14] netlink: add documentation for memory mapped I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e17db69-0d5c-40dc-81ac-2904aab008c3@email.android.com>
Date:	Wed, 17 Apr 2013 20:08:06 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Daniel Borkmann <dborkman@...hat.com>
CC:	davem@...emloft.net, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 12/14] netlink: add documentation for memory mapped I/O



Daniel Borkmann <dborkman@...hat.com> schrieb:

>On 04/17/2013 06:47 PM, Patrick McHardy wrote:
>> Signed-off-by: Patrick McHardy <kaber@...sh.net>
>> ---
>[...]
>> +Ring frames
>> +------------
>> +
>> +Each frames contain a frame header, consisting of a synchronization
>word and some
>> +meta-data, and the message itself.
>> +
>> +Frame:	[ header message ]
>> +
>> +The frame header is defined as follows:
>> +
>> +struct nl_mmap_hdr {
>> +	unsigned int	nm_status;
>> +	unsigned int	nm_len;
>> +	__u32		nm_group;
>> +	/* credentials */
>> +	__u32		nm_pid;
>> +	__u32		nm_uid;
>> +	__u32		nm_gid;
>> +};
>
>Hm, just wondering, maybe it could be a safer path to make 'nm_status'
>and 'nm_len' also of fixed width as the rest of nl_mmap_hdr, and as in
>PF_PACKET's tpacket2_hdr and tpacket3_hdr ?
>--
>To unsubscribe from this list: send the line "unsubscribe
>netfilter-devel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

The size of int is not going to change, but I agree that it is cleaner. I'll send a patch to change this once/if this is merged.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html