netdev - Re: [PATCH net-next v3 1/1] net: fec: Enable imx6 enet checksum acceleration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Apr 2013 14:37:50 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jim Baxter <jim_baxter@...tor.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Fugang Duan <B38611@...escale.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/1] net: fec: Enable imx6 enet checksum
 acceleration.

On Wed, 2013-04-17 at 21:07 +0100, Jim Baxter wrote:
> Enables hardware generation of IP header and
> protocol specific checksums for transmitted
> packets.
> 
> Enabled hardware discarding of received packets with
> invalid IP header or protocol specific checksums.
> 
> The feature is enabled by default but can be
> enabled/disabled by ethtool.
> 
> Signed-off-by: Fugang Duan <B38611@...escale.com>
> Signed-off-by: Jim Baxter <jim_baxter@...tor.com>
> ---
>  
> +static void
> +fec_enet_clear_csum(struct sk_buff *skb, struct net_device *ndev)
> +{
> +	int hdr_len = 0;
> +
> +	/* Only run for packets requiring a checksum. */
> +	if (skb->ip_summed != CHECKSUM_PARTIAL)
> +		return;
> +	if (skb->len < (ETH_HLEN + sizeof(struct iphdr)))
> +		return;
> +

You could do the skb_cow_head() here.

> +	if (skb->protocol == htons(ETH_P_IP)) {
> +		ip_hdr(skb)->check = 0;
> +
> +		switch (ip_hdr(skb)->protocol) {
> +		case IPPROTO_UDP:
> +			hdr_len = (ETH_HLEN +
> +					(ip_hdr(skb)->ihl << 2) +
> +					sizeof(struct udphdr));
> +			if (skb->len < hdr_len)
> +				return;
> +			skb_cow_head(skb, hdr_len);

You should not ignore the return value...

> +			skb_set_transport_header(skb,
> +					ETH_HLEN + ip_hdrlen(skb));
> +			udp_hdr(skb)->check = 0;
> +			break;
> +		case IPPROTO_TCP:
> +			hdr_len = (ETH_HLEN +
> +					(ip_hdr(skb)->ihl << 2) +
> +					sizeof(struct tcphdr));
> +			if (skb->len < hdr_len)
> +				return;
> +			skb_cow_head(skb, hdr_len);

same here

> +			if (tcp_hdr(skb))
> +				tcp_hdr(skb)->check = 0;
> +			break;
> +		case IPPROTO_ICMP:
> +			hdr_len = (ETH_HLEN +
> +					(ip_hdr(skb)->ihl << 2) +
> +					sizeof(struct icmphdr));
> +			if (skb->len < hdr_len)
> +				return;
> +			skb_cow_head(skb, hdr_len);

same here

> +			if (icmp_hdr(skb))
> +				icmp_hdr(skb)->checksum = 0;
> +			break;
> +		default:
> +			break;
> +		}
> +	}
> +}
> +



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html