netdev - Re: [PATCH 5/5] ks8851: Remove unneeded PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <516E40EB.5080505@metafoo.de>
Date:	Wed, 17 Apr 2013 08:27:55 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	David Miller <davem@...emloft.net>
CC:	fabio.estevam@...escale.com, netdev@...r.kernel.org,
	joe@...ches.com
Subject: Re: [PATCH 5/5] ks8851: Remove unneeded PM_OPS definitions

On 04/16/2013 10:37 PM, David Miller wrote:
> From: Lars-Peter Clausen <lars@...afoo.de>
> Date: Tue, 16 Apr 2013 22:29:37 +0200
> 
>> On 04/16/2013 09:28 PM, Fabio Estevam wrote:
>>> SIMPLE_DEV_PM_OPS macro can handle !CONFIG_PM_SLEEP case nicely, so there is no
>>> need to define PM_OPS for both CONFIG_PM_SLEEP and !CONFIG_PM_SLEEP cases.
>>>
>>> Remove the unneeded definitions.
>>>
>>> Cc: Lars-Peter Clausen <lars@...afoo.de>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
>>
>> yea, but now you have the dev_pm_ops struct, even if pm is disabled.
> 
> That's fine, it allows the functions to be compile tested in all
> configurations.

The functions are still protected by a #ifdef, it's just the dev_pm_ops struct
which is not anymore.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html