netdev - Re: [PATCH] net/cpsw: don't disable_irqs() after an interrupt has been received.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516E52EC.60901@linutronix.de>
Date:	Wed, 17 Apr 2013 09:44:44 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Mugunthan V N <mugunthanvnm@...com>
CC:	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] net/cpsw: don't disable_irqs() after an interrupt has
 been received.

On 04/17/2013 08:19 AM, Mugunthan V N wrote:
> When using cpsw_intr_disable, it actually only disables future interrupts
> from CPSW ip. But the current interrupt generated to interrupt controller
> will be still pending and will not allow ARM to do any thing till either
> interrups is disabled or acked, thus CPU will be in CPSW ISR continuously
> and system will hang. This patch is applicable only when kernel is always
> built with RT enabled which is not the current case in Vanilla kernel

I am not talking about RT, just threaded interrupts but yes I saw the
problem first with RT.

> I have tested this patch and it hangs the CPU after net open (CPSW init).

If I remove additionally the napi_schedule() piece then the network is
dead (as expected) and the system continues to work (and I receive
interrupts) and the ISR for cpsw is not executed again. What hardware /
CPU do you have?

> 
> Regards
> Mugunthan V N

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html