netdev - Re: [PATCH V5 6/7] xen-netback: coalesce slots in TX path and fix regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366206801.25579.47.camel@zakaz.uk.xensource.com>
Date:	Wed, 17 Apr 2013 14:53:21 +0100
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>,
	"annie.li@...cle.com" <annie.li@...cle.com>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	"jbeulich@...e.com" <jbeulich@...e.com>,
	"wdauchy@...il.com" <wdauchy@...il.com>,
	David Vrabel <david.vrabel@...rix.com>
Subject: Re: [PATCH V5 6/7] xen-netback: coalesce slots in TX path and fix
 regressions

On Mon, 2013-04-15 at 18:06 +0100, Wei Liu wrote:
> This patch tries to coalesce tx requests when constructing grant copy
> structures. It enables netback to deal with situation when frontend's
> MAX_SKB_FRAGS is larger than backend's MAX_SKB_FRAGS.
> 
> With the help of coalescing, this patch tries to address two regressions and
> avoid reopening the security hole in XSA-39.
> 
> Regression 1. The reduction of the number of supported ring entries (slots)
> per packet (from 18 to 17). This regression has been around for some time but
> remains unnoticed until XSA-39 security fix. This is fixed by coalescing
> slots.
> 
> Regression 2. The XSA-39 security fix turning "too many frags" errors from
> just dropping the packet to a fatal error and disabling the VIF. This is fixed
> by coalescing slots (handling 18 slots when backend's MAX_SKB_FRAGS is 17)
> which rules out false positive (using 18 slots is legit) and dropping packets
> using 19 to `max_skb_slots` slots.
> 
> To avoid reopening security hole in XSA-39, frontend sending packet using more
> than max_skb_slots is considered malicious.
> 
> The behavior of netback for packet is thus:
> 
>     1-18            slots: valid
>    19-max_skb_slots slots: drop and respond with an error
>    max_skb_slots+   slots: fatal error
> 
> max_skb_slots is configurable by admin, default value is 20.
> 
> Also change variable name from "frags" to "slots" in netbk_count_requests.
> 
> Please note that RX path still has dependency on MAX_SKB_FRAGS. This will be
> fixed with separate patch.
> 
> Signed-off-by: Wei Liu <wei.liu2@...rix.com>

Acked-by: Ian Campbell <ian.campbell@...rix.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html