lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Apr 2013 11:36:55 -0400 From: Vlad Yasevich <vyasevich@...il.com> To: Daniel Borkmann <dborkman@...hat.com> CC: davem@...emloft.net, netdev@...r.kernel.org, linux-sctp@...r.kernel.org Subject: Re: [PATCH net-next 9/9] net: sctp: sctp_ulpq: do not use char as a struct member On 04/16/2013 05:07 PM, Daniel Borkmann wrote: > Replace char with a more appropriate __u8 bitfield for pd_mode. > > Signed-off-by: Daniel Borkmann <dborkman@...hat.com> > --- > include/net/sctp/ulpqueue.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/sctp/ulpqueue.h b/include/net/sctp/ulpqueue.h > index 00e50ba..a2bebd4 100644 > --- a/include/net/sctp/ulpqueue.h > +++ b/include/net/sctp/ulpqueue.h > @@ -49,10 +49,10 @@ > > /* A structure to carry information to the ULP (e.g. Sockets API) */ > struct sctp_ulpq { > - char pd_mode; > struct sctp_association *asoc; > struct sk_buff_head reasm; > struct sk_buff_head lobby; > + __u8 pd_mode:1; > }; > > /* Prototypes. */ > This one is a bit pointless. You are not saving any space and making generated code worse. -vlad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists