[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130418.145257.179706081574088947.davem@davemloft.net>
Date: Thu, 18 Apr 2013 14:52:57 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: jeffrey.t.kirsher@...el.com
Cc: gregory.v.rose@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
sassmann@...hat.com
Subject: Re: [net 2/2] ixgbe: Fix a bug in setting VF VLAN via PF
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 17 Apr 2013 23:41:35 -0700
> From: Greg Rose <gregory.v.rose@...el.com>
>
> The PF driver does not check if the administrator has already set a VF
> VLAN via the PF driver before setting the new VLAN. This results in
> the following scenario:
>
> A) Administrator sets VF <n> to VLAN 100
> B) Administrator sets VF <x> to VLAN 100
> C) Administrator sets VF <n> to VLAN 200
> D) The VF <n> driver continues to be able to receive traffic on VLAN
> 100 because the VLVFB pool enable bit for that VF was left set
> instead of being cleared as it should be.
>
> This fix ensures that the old VLAN filter for VF <n> is first removed
> and the pool bit enable for VF <n> is cleared so that it no longer
> receives traffic on VLAN 100.
>
> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
> Tested-by: Sibai Li <sibai.li@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists