lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 18 Apr 2013 15:09:10 -0400 (EDT)
From:	David Miller <>
Subject: Re: Bonding driver has bad load balancing for forwarded traffic,

From: Eric Dumazet <>
Date: Mon, 15 Apr 2013 20:03:24 -0700

> [PATCH] bonding: fix l23 and l34 load balancing in forwarding path
> Since commit 6b923cb7188d46 (bonding: support for IPv6 transmit hashing)
> bonding doesn't properly hash traffic in forwarding setups.
> Vitaly V. Bursov diagnosed that skb_network_header_len() returned 0 in
> this case.
> More generally, the transport header might not be in the skb head.
> Use pskb_may_pull() & skb_header_pointer() to get it right, and use
> proto_ports_offset() in bond_xmit_hash_policy_l34() to get support for
> more protocols than TCP and UDP.
> Reported-by: Vitaly V. Bursov <>
> Signed-off-by: Eric Dumazet <>

Applied and queued up for -stable, but:

> +						sizeof(_l4), &_l4);						

That's some rather amazing trailing whitespace.  Are you trying to break
free of earth's atmosphere? :-)
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists