netdev - Re: [PATCH net-next v3 1/1] net: fec: Enable imx6 enet checksum acceleration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516FC886.7040303@mentor.com>
Date:	Thu, 18 Apr 2013 11:18:46 +0100
From:	Jim Baxter <jim_baxter@...tor.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Fugang Duan <B38611@...escale.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 1/1] net: fec: Enable imx6 enet checksum acceleration.

Thank you for you comments, I will fix the issues.
One question below:

On 17/04/13 23:45, Francois Romieu wrote:
>> +static int fec_set_features(struct net_device *netdev,
>> +	netdev_features_t features)
>> +{
>> +	struct fec_enet_private *fep = netdev_priv(netdev);
>> +	netdev_features_t changed = features ^ netdev->features;
>> +	bool restart_required = false;
>> +
>> +	netdev->features = features;
>> +
>> +	/* Receive checksum has been changed */
>> +	if (changed & NETIF_F_RXCSUM) {
>> +		restart_required = true;
>> +		if (features & NETIF_F_RXCSUM)
>> +			fep->csum_flags |= FLAG_RX_CSUM_ENABLED;
>> +		else
>> +			fep->csum_flags &= ~FLAG_RX_CSUM_ENABLED;
> 
> ---(snip)----8<------------------------------------------------
> 
>> +	}
>> +
>> +	/* Restart the network interface */
>> +	if (true == restart_required) {
> 
> ---(snip)--------------------------------------->8-------------
> 
> Then remove the "restart_required" variable ?
> 
What you mean by remove the "restart_required" variable, I only want a
restart in certain situations? Am I misunderstanding you comment?

Jim
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html