netdev - Re: [PATCH] fec: Remove unneeded asm header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5CDi67MGd0Du+bM7FR8RGDf8rVMZJQuq_8B2A-qd3W7EQ@mail.gmail.com>
Date:	Thu, 18 Apr 2013 09:42:09 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Greg Ungerer <gerg@...inux.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] fec: Remove unneeded asm header files

Hi Greg,

On Thu, Apr 18, 2013 at 9:00 AM, Greg Ungerer <gerg@...inux.org> wrote:

> fec_main.c?  That doesn't exist in linux-3.9-rc7.
> Comments and tests below based on fec.c in linux-3.9-rc7.

Yes, fec.c  got was renamed to fec_main.c in net-next:
https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/drivers/net/ethernet/freescale/fec_main.c

>> -#include <asm/cacheflush.h>
>
> There is a rather bogus looking call to flush_cache_all() conditional
> on CONFIG_M532x, and I suspect removing this include will break that.

Ok, will keep <asm/cacheflush.h> in v2 then.

>> -#ifndef CONFIG_ARM
>> -#include <asm/coldfire.h>
>> -#include <asm/mcfsim.h>
>> -#endif
>
> No problem with this part. I compiled for a couple of ColdFire targets
> and this is ok.

Thanks for testing, Greg.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html