netdev - RE: [PATCH 2/6] net: vlan: prepare for 802.1ad VLAN filtering offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f014543-1641-4487-a0a6-30ddb364e328@email.android.com>
Date:	Fri, 19 Apr 2013 18:42:30 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 2/6] net: vlan: prepare for 802.1ad VLAN filtering offload



"Allan, Bruce W" <bruce.w.allan@...el.com> schrieb:

>> -----Original Message-----
>> From: netdev-owner@...r.kernel.org [mailto:netdev-
>> owner@...r.kernel.org] On Behalf Of Patrick McHardy
>> Sent: Friday, April 19, 2013 5:04 AM
>> To: davem@...emloft.net
>> Cc: netdev@...r.kernel.org
>> Subject: [PATCH 2/6] net: vlan: prepare for 802.1ad VLAN filtering
>offload
>> 
>> Change the rx_{add,kill}_vid callbacks to take a protocol argument in
>> preparation of 802.1ad support. The protocol argument used so far is
>> always htons(ETH_P_8021Q).
>> 
>> Signed-off-by: Patrick McHardy <kaber@...sh.net>
>> ---
>>  drivers/net/bonding/bond_main.c                   | 17 ++++----
>>  drivers/net/ethernet/adaptec/starfire.c           |  6 ++-
>>  drivers/net/ethernet/brocade/bna/bnad.c           |  6 +--
>>  drivers/net/ethernet/cisco/enic/enic_dev.c        |  4 +-
>>  drivers/net/ethernet/cisco/enic/enic_dev.h        |  4 +-
>>  drivers/net/ethernet/emulex/benet/be_main.c       |  4 +-
>>  drivers/net/ethernet/ibm/ehea/ehea_main.c         |  4 +-
>>  drivers/net/ethernet/intel/e1000/e1000_main.c     | 22 +++++++----
>>  drivers/net/ethernet/intel/e1000e/netdev.c        | 20 ++++++----
>>  drivers/net/ethernet/intel/igb/igb_main.c         | 12 +++---
>>  drivers/net/ethernet/intel/igbvf/netdev.c         |  8 ++--
>>  drivers/net/ethernet/intel/ixgb/ixgb_main.c       | 12 +++---
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c     | 10 +++--
>>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |  9 +++--
>>  drivers/net/ethernet/mellanox/mlx4/en_netdev.c    |  6 ++-
>>  drivers/net/ethernet/neterion/vxge/vxge-main.c    |  8 ++--
>>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c  |  8 ++--
>>  drivers/net/ethernet/qlogic/qlge/qlge_main.c      |  4 +-
>>  drivers/net/ethernet/renesas/sh_eth.c             |  6 ++-
>>  drivers/net/ethernet/tehuti/tehuti.c              |  4 +-
>>  drivers/net/ethernet/ti/cpsw.c                    |  4 +-
>>  drivers/net/ethernet/via/via-rhine.c              | 10 +++--
>>  drivers/net/ethernet/via/via-velocity.c           |  6 ++-
>>  drivers/net/macvlan.c                             |  8 ++--
>>  drivers/net/team/team.c                           | 10 ++---
>>  drivers/net/virtio_net.c                          |  6 ++-
>>  drivers/net/vmxnet3/vmxnet3_drv.c                 |  4 +-
>>  drivers/s390/net/qeth_l2_main.c                   |  6 ++-
>>  drivers/s390/net/qeth_l3_main.c                   |  6 ++-
>>  include/linux/if_vlan.h                           |  4 +-
>>  include/linux/netdevice.h                         | 16 ++++----
>>  net/8021q/vlan.c                                  | 10 ++---
>>  net/8021q/vlan_core.c                             | 47
>+++++++++++++----------
>>  net/bridge/br_vlan.c                              | 10 +++--
>>  34 files changed, 184 insertions(+), 137 deletions(-)
>
>For those drivers which do not use the protocol argument in their
>rx_{add,kill}_vid callbacks,
>please add the __always_unused attribute.

Why? Its a function argument, not a local variable, its perfectly fine not to use it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html