netdev - Re: [PATCH] rps: selective flow shedding during softnet overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366399300.16391.49.camel@edumazet-glaptop>
Date:	Fri, 19 Apr 2013 12:21:40 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com
Subject: Re: [PATCH] rps: selective flow shedding during softnet overflow

On Fri, 2013-04-19 at 12:03 -0700, Stephen Hemminger wrote:

> The netdev_backlog only applies for RPS and non-NAPI devices.
> So this won't help if receive packet steering is not enabled.

Yes, the point is exactly using RPS as a proxy to control
the behavior and better distribute the load.

> Seems like a deficiency in the receive steering design rather
> than the netdev_backlog.

Well, RPS works well, even for multiqueue NICS. But nobody said it was
perfect.

Back to NAPI (without RPS) :

If one RX queue (multiqueue device or not) is hit by a single flow, how
do you plan to do anything, since without RPS we process each packet
after another.

There is no queue building up in our stack. (Only queue is in the NIC RX
ring). Eventually NIC drops packets.

> 
> Can't you do this with existing ingress stuff?

ingress is not yet multiqueue enabled, AFAIK.

Expect very poor performance from it.

> The trend seems to be put in more fixed infrastructure to deal with
> performance and server problems rather than building general purpose
> solutions.

OK, I see you want to push netmap. Lets talk about general purpose
solutions.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html