netdev - Re: [PATCH 5/6] net: vlan: add 802.1ad support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f54a08d-f3d8-435f-b2f3-09f36858280f@email.android.com>
Date:	Fri, 19 Apr 2013 22:45:03 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>, bhutchings@...arflare.com
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/6] net: vlan: add 802.1ad support



David Miller <davem@...emloft.net> schrieb:

>From: Ben Hutchings <bhutchings@...arflare.com>
>Date: Fri, 19 Apr 2013 21:03:03 +0100
>
>> These need to be given names in the netdev_features_strings array in
>> net/core/ethtool.c
>
>Thanks, I'm about to commit the following:
>
>====================
>[PATCH] net: Add missing netdev feature strings for
>NETIF_F_HW_VLAN_STAG_*
>
>Noticed by Ben Hutchings.
>
>Signed-off-by: David S. Miller <davem@...emloft.net>
>---
> net/core/ethtool.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/net/core/ethtool.c b/net/core/ethtool.c
>index b87712c..5a934ef 100644
>--- a/net/core/ethtool.c
>+++ b/net/core/ethtool.c
>@@ -64,6 +64,9 @@ static const char
>netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN]
> 
> 	[NETIF_F_HW_VLAN_CTAG_RX_BIT] =  "rx-vlan-ctag-hw-parse",
> 	[NETIF_F_HW_VLAN_CTAG_FILTER_BIT] = "rx-vlan-ctag-filter",
>+	[NETIF_F_HW_VLAN_STAG_TX_BIT] =  "tx-vlan-stag-hw-insert",
>+	[NETIF_F_HW_VLAN_STAG_RX_BIT] =  "rx-vlan-stag-hw-parse",
>+	[NETIF_F_HW_VLAN_STAG_FILTER_BIT] = "rx-vlan-stag-filter",
> 	[NETIF_F_VLAN_CHALLENGED_BIT] =  "vlan-challenged",
> 	[NETIF_F_GSO_BIT] =              "tx-generic-segmentation",
> 	[NETIF_F_LLTX_BIT] =             "tx-lockless",

Thanks Dave,

there seem to be a couple of more problems. Sorry about that, I tried to enable as much drivers as possible and review everything manually, obviously I missed some problems. I'll take care of them as soon as I get home.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html