netdev - RE: rtl8168e-vl dropping tftp ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DFF62ECF5DF14C65A71A35581D58FFA9@realtek.com.tw>
Date:	Fri, 19 Apr 2013 11:27:11 +0800
From:	hayeswang <hayeswang@...ltek.com>
To:	'Francois Romieu' <romieu@...zoreil.com>,
	'Stefan Bader' <stefan.bader@...onical.com>
CC:	<netdev@...r.kernel.org>, 'nic_swsd' <nic_swsd@...ltek.com>
Subject: RE: rtl8168e-vl dropping tftp ack

Francois Romieu [mailto:romieu@...zoreil.com] 
> Sent: Friday, April 19, 2013 5:55 AM
> To: Stefan Bader
> Cc: netdev@...r.kernel.org; nic_swsd
> Subject: Re: rtl8168e-vl dropping tftp ack
> 
[...]
> +		if (unlikely(skb->len < ETH_ZLEN &&
> +		    (tp->mac_version == RTL_GIGA_MAC_VER_34))) {
> +			if (skb_padto(skb, ETH_ZLEN))
> +				return false;
> +			skb_checksum_help(skb);
> +			skb_put(skb, ETH_ZLEN - skb->len);
> +			return true;
> +		}
> +

I don't think the hw checksum is enabled, because there are many successful
small packets before the failure. However, I also want to know if any skb->len <
60 occurs, so I think the checking should be included by the other case.
 
Best Regards,
Hayes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html