netdev - Re: [net-next PATCH 1/3] net: fix race bug in fragmentation create code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130419010006.GE27889@order.stressinduktion.org>
Date:	Fri, 19 Apr 2013 03:00:06 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Jesper Dangaard Brouer <brouer@...hat.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [net-next PATCH 1/3] net: fix race bug in fragmentation create code

On Thu, Apr 18, 2013 at 11:37:27PM +0200, Jesper Dangaard Brouer wrote:
> During creation of a new inet_frag_queue, the lru_list pointer is
> updated after releasing the hash bucket lock, which can lead to a
> race condition (and panic), if the inet_frag_queue is deleted
> (very quickly) before the lru_list is valid.
> 
> This race condition is should not be able to occur with current
> LRU based evictor.  For the planned direct hash based
> evictor/clean strategy, this race condition is more likely to
> occur.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> ---
> 
>  net/ipv4/inet_fragment.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
> index e97d66a..beec05b 100644
> --- a/net/ipv4/inet_fragment.c
> +++ b/net/ipv4/inet_fragment.c
> @@ -283,9 +283,9 @@ static struct inet_frag_queue *inet_frag_intern(struct netns_frags *nf,
>  
>  	atomic_inc(&qp->refcnt);
>  	hlist_add_head(&qp->list, &hb->chain);
> +	inet_frag_lru_add(nf, qp);
>  	spin_unlock(&hb->chain_lock);
>  	read_unlock(&f->lock);
> -	inet_frag_lru_add(nf, qp);
>  	return qp;
>  }

If I checked correctly, the current code does not have the race
condition? I think this change is ok but maybe we can defer it until
the direct hash cleanup patches land?

Thanks,

  Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html