netdev - Re: [PATCH] e1000: limit udelay for phy changes to 10000us

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130421142713.GU16732@two.firstfloor.org>
Date:	Sun, 21 Apr 2013 16:27:13 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	Andi Kleen <andi@...stfloor.org>, netdev@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] e1000: limit udelay for phy changes to 10000us

On Sat, Apr 20, 2013 at 08:34:45PM -0700, Jeff Kirsher wrote:
> On Sat, 2013-04-20 at 20:31 -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@...ux.intel.com>
> > 
> > If you really want 100000us you should really use mdelay or so.
> > 
> > Found by the LTO kernel build
> > 
> > Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> > ---
> >  drivers/net/ethernet/intel/igb/e1000_phy.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-) 
> 
> Thanks Andi, I will add the patch to my igb queue.  Do you want me to
> fix up the patch title as well? :-) (s/e1000/igb/)

Sure please fix.

BTW I'm not sure my fix/value is right. If you really need 100000us you need
some other mechanism to wait.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html